refactor: address emmylua diagnostics

after/lsp/bashls.lua

@@ -7,7 +7,7 @@ return {
         "bash",
         "zsh",
     },
-    on_attach = function(client, bufnr)
+    on_attach = function(_, bufnr)
         vim.keymap.set("n", "<leader>lf", function()
             util.format({
                 buf = bufnr,

after/lsp/clangd.lua

@@ -12,7 +12,7 @@ return {
         "--enable-config",
     },
     single_file_support = true,
-    on_attach = function(client, bufnr)
+    on_attach = function(_, bufnr)
         Linter.add(bufnr, {
             cmd = {
                 "clang-tidy",

after/lsp/emmylua_ls.lua

@@ -1,5 +1,3 @@
-local lsp = require("lsp")
-
 local lua_library_paths = { vim.env.VIMRUNTIME }
 vim.list_extend(lua_library_paths, require("pack").get_paths())
 
@@ -7,17 +5,17 @@ vim.list_extend(lua_library_paths, require("pack").get_paths())
 return {
     settings = {
         emmylua = {
-            format = {
-                useDiff = true,
-                externalTool = {
-                    program = "luafmt",
-                    args = {
-                        "--stdin",
-                        "--level=lua-jit",
-                        "--config=.luafmt.toml",
-                    }
+            diagnostics = {
+                disable = {
+                    "unnecessary-if",
+                    "preferred-local-alias",
+                    "redefined-local",
                 },
             },
+            format = {
+                -- Re-enable once luafmt is integrated in server
+                -- useDiff = true,
+            },
             runtime = {
                 version = "LuaJIT",
                 requirePattern = {
@@ -33,5 +31,37 @@ return {
             },
         }
     },
-    on_attach = lsp.on_attach,
+    on_attach = function(_, bufnr)
+        local util = require("util")
+
+        vim.keymap.set("n", "<leader>lf", function()
+            util.format({
+                buf = bufnr,
+                cmd = {
+                    "stylua",
+                    "--stdin-filepath",
+                    "%file%",
+                    "-",
+                },
+                output = "stdout",
+            })
+        end, { buffer = bufnr })
+
+        vim.keymap.set("x", "<leader>lf", function()
+            util.format({
+                buf = bufnr,
+                cmd = {
+                    "stylua",
+                    "--range-start",
+                    "%byte_start%",
+                    "--range-end",
+                    "%byte_end%",
+                    "--stdin-filepath",
+                    "%file%",
+                    "-",
+                },
+                output = "stdout",
+            })
+        end, { buffer = bufnr })
+    end,
 }

after/lsp/gopls.lua

@@ -11,7 +11,7 @@ return {
             },
         },
     },
-    on_attach = function(client, bufnr)
+    on_attach = function(_, bufnr)
         vim.keymap.set("n", "<leader>lf", function()
             util.format({
                 buf = bufnr,

after/lsp/intelephense.lua

@@ -11,7 +11,7 @@ return {
             },
         },
     },
-    on_attach = function(client, bufnr)
+    on_attach = function(_, bufnr)
         Linter.add(bufnr, {
             cmd = {
                 "phpcs",

after/lsp/lua_ls.lua

@@ -1,73 +0,0 @@
-local lua_library_paths = { vim.env.VIMRUNTIME }
-vim.list_extend(lua_library_paths, require("pack").get_paths())
-
----@type vim.lsp.Config
-return {
-    settings = {
-        Lua = {
-            codeLens = {
-                enable = true,
-            },
-            completion = {
-                callSnippet = "Replace",
-                keywordSnippet = "Replace",
-                showWord = "Disable",
-            },
-            runtime = {
-                version = "LuaJIT",
-                path = {
-                    "lua/?.lua",
-                    "lua/?/init.lua",
-                },
-                pathStrict = true,
-            },
-            workspace = {
-                library = lua_library_paths,
-                checkThirdParty = false,
-            },
-            hint = {
-                enable = false,
-                arrayIndex = "Disable",
-                await = true,
-                paramName = "All",
-                paramType = true,
-                semicolon = "Disable",
-                setType = true,
-            },
-            telemetry = { enable = false },
-        },
-    },
-    on_attach = function(_, bufnr)
-        local util = require("util")
-
-        vim.keymap.set("n", "<leader>lf", function()
-            util.format({
-                buf = bufnr,
-                cmd = {
-                    "stylua",
-                    "--stdin-filepath",
-                    "%file%",
-                    "-",
-                },
-                output = "stdout",
-            })
-        end, { buffer = bufnr })
-
-        vim.keymap.set("x", "<leader>lf", function()
-            util.format({
-                buf = bufnr,
-                cmd = {
-                    "stylua",
-                    "--range-start",
-                    "%byte_start%",
-                    "--range-end",
-                    "%byte_end%",
-                    "--stdin-filepath",
-                    "%file%",
-                    "-",
-                },
-                output = "stdout",
-            })
-        end, { buffer = bufnr })
-    end,
-}

after/lsp/ruff.lua

@@ -2,7 +2,7 @@ local util = require("util")
 
 ---@type vim.lsp.Config
 return {
-    on_attach = function(client, bufnr)
+    on_attach = function(_, bufnr)
         vim.keymap.set("n", "<leader>lf", function()
             vim.lsp.buf.format()
             util.format({